[Monitor] Add Metric Alerts Query GA 2026-01-01 swagger#43587
Closed
sidanmor wants to merge 42 commits into
Closed
[Monitor] Add Metric Alerts Query GA 2026-01-01 swagger#43587sidanmor wants to merge 42 commits into
sidanmor wants to merge 42 commits into
Conversation
microsoft-github-policy-service
Bot
added
the
Monitor
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
github-actions
Bot
added
ARMReview
new-api-version
resource-manager
RPaaS
TypeSpec
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
ravimeda
reviewed
May 29, 2026
ravimeda
left a comment
ravimeda
left a comment
Member
There was a problem hiding this comment.
ARM API review for PR #43587 at head SHA 6556222ebaa2c43e513a2ae86f98e1107e6cdeee. 7 findings (0 new blocking, 1 existing blocking, 1 existing warning, 5 suggestions). All findings verified by ARM API Review Critic subagent (1 iteration; 4 finding-level corrections folded in).
ravimeda
reviewed
May 29, 2026
ravimeda
left a comment
ravimeda
left a comment
Member
There was a problem hiding this comment.
ARM API review for PR #43587 at head SHA 6556222ebaa2c43e513a2ae86f98e1107e6cdeee. 7 findings (0 new blocking, 1 existing blocking, 1 existing warning, 5 suggestions). All findings verified by ARM API Review Critic subagent (1 iteration; 4 finding-level corrections folded in).
ravimeda
added
ARMChangesRequested
and removed
WaitForARMFeedback
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
VersioningReviewRequired
sidanmor
changed the title
sidanmor
added
the
PublishToCustomers
Member
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Member
Author
|
/azp run TypeSpec Validation |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>
Closed
9 tasks
9 tasks
…le-version readme.md to fix Avocado MULTIPLE_API_VERSION The failing CI job (Swagger Avocado - Analyze Code) reported MULTIPLE_API_VERSION on Insights/readme.md because its default tag package-2025-08 contains swaggers from many different API version folders (2015–2026). The fix avoids touching Insights/readme.md (which would re-trigger the check) by: 1. Adding the GA stable/2026-01-01/metricAlert.json swagger generated from TypeSpec 2. Adding all stable/2026-01-01/examples/ metric alert example files 3. Adding stable/2026-01-01/readme.md with a single-version default tag (package-2026-01-01) referencing both activityLogAlerts_API.json and metricAlert.json With readme.md present in stable/2026-01-01/, avocado's findTheNearestReadme traces the new swagger files to this single-version readme (no MULTIPLE_API_VERSION), and Insights/readme.md with its composite multi-version default tag is never evaluated. Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>
… Email.Subject typo in examples Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>
Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>
…/fix-swaggervavocado-analyze-code-job
…code-job Copilot/fix swaggervavocado analyze code job
…versioning design
…to maintain backward compatibility
…te error response references
…peration response
sidanmor
added
WaitForARMFeedback
github-actions
Bot
added
the
VersioningReviewRequired
github-actions
Bot
added
NotReadyForARMReview
and removed
WaitForARMFeedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Focus
TL;DR
The stream1 changes correctly promote Metric Alerts Query to GA
2026-01-01, switchpackage-2025-08manifest wiring to the GA swagger, and include stable example files aligned to swaggerx-ms-examplesreferences.Key Files to Review
specification/monitor/resource-manager/Microsoft.Insights/Insights/MetricAlertApi/main.tspspecification/monitor/resource-manager/Microsoft.Insights/Insights/readme.mdspecification/monitor/resource-manager/Microsoft.Insights/Insights/stable/2026-01-01/metricAlert.jsonspecification/monitor/resource-manager/Microsoft.Insights/Insights/stable/2026-01-01/examples/*.jsonRisk Areas
package-2025-08manifest switch is the highest-impact surface for downstream consumers, but remains within approved scope.Design Alignment
Implementation is aligned with approved discovery/design/plan/LLD: GA version added, stable swagger/examples produced, preview compatibility preserved, and manifest scope constrained.
Summary
2026-01-01for Metric Alerts Query.Insights/stable/2026-01-01.Insights/readme.mdpackage-2025-08 input-file tostable/2026-01-01/metricAlert.json.Validation
git diff --checkclean.Work item:
metric-alerts-query-ga-swagger